Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: add sign script #105

Closed
wants to merge 1 commit into from

Conversation

NinhDoan
Copy link

@NinhDoan NinhDoan commented Dec 6, 2023

Hi
I just added file sign_script to help people use their own scripts, could you take a look at it and confirm that it works correctly?
Many thanks

@VuDn5
Copy link

VuDn5 commented Dec 14, 2023

@dkmstr ... and here, please review ít,

@dkmstr
Copy link
Collaborator

dkmstr commented Dec 14, 2023

Hi, the first problem with the script you provide is that it uses "pycrypto", and it's discontinued... :(

https://www.pycrypto.org/

Maybe you are using pycryptodome, but anyway, it's not coherent with rest of uds code that uses cryptography... Hope you understand this.

Also, in order to include something like that to be useful, we need to include some more data, so it's really helpfull for the rest of people (Till today, no one has requested never to sign client scripts, until you ofc :) )

  1. We need to explain WHERE change the public and private key

    • Include some documentation, what needs to be changed (that is, all EXISTING signatures, and the public check key on uds client...)
    • Explain that standard provided scripts and clients will not work with these
    • Explain that the best method to include some new functionality is, after doing it, request for us to sign it
    • Whatever...
  2. Make the sign script using python cryptography api

Regards,

@dkmstr dkmstr closed this Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants