Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testimonial carousel on homepage #467

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

mountainmort
Copy link
Contributor

@mountainmort mountainmort commented May 23, 2023

Description

  • Refactored existing Testimonials into a JSON object with capability to retrieve testimonials by Name, ID, or retrieve all Testimonials.
  • Created TestimonialCard component based on the testimonial divs that existed on the Testimonials page.
  • Updated the Testimonial page to pull all testimonials from the new Testimonials utility and use the TestimonialCard component.
  • Refactored the Testimonial on the Donate page to use the new retrieve testimonial by Name endpoint and TestimonialCard.
  • Created a TestimonialCarousel component that allows scrolling through all available Testimonials, and embedded this on the home page.
    • Note: I used nuka-carousel here as this library was already in the project and used for the SponsorSlider component.

Related Issue

#466

Motivation and Context

The big dog requested it get done, so it got done.

How Has This Been Tested?

  • Verified pages that were updated remain the same (Testimonials, Donate)
  • Verified Home page works with across our different size screens and independent of theme
  • Tests are passing

Screenshots (if appropriate):

  1. Home Page with carousel - light mode / desktop
    image

  2. Home Page with carousel - dark mode / desktop
    image

  3. Home Page with carousel - light mode / mobile
    image

  4. Home Page with carousel - dark mode / mobile
    image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I'd be interested in getting some feedback here on what unit tests I should/could include.

@vercel
Copy link

vercel bot commented May 23, 2023

Someone is attempting to deploy a commit to the vetswhocode-web-app Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant