Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging utility and refactor app structure #22

Merged
merged 3 commits into from
Nov 30, 2024
Merged

Add logging utility and refactor app structure #22

merged 3 commits into from
Nov 30, 2024

Conversation

Sfayson1
Copy link
Contributor

Add logging setup to utils directory

  • Created setup_logging function in logging_utils.py
  • Configured logging with file and stream handlers
  • Updated main script to use the new logging setup

@Sfayson1 Sfayson1 self-assigned this Nov 21, 2024
@Sfayson1 Sfayson1 linked an issue Nov 21, 2024 that may be closed by this pull request
Logging #19
Closed
@jeromehardaway jeromehardaway marked this pull request as draft November 22, 2024 00:08
@jeromehardaway
Copy link
Collaborator

@Sfayson1 you should mock the api key in this file:

test_streamlit_app.py

@Sfayson1 Sfayson1 marked this pull request as ready for review November 26, 2024 01:33
@jonulak jonulak merged commit cd3f1c8 into main Nov 30, 2024
1 check passed
@jonulak jonulak deleted the sfayson1/logging branch November 30, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonulak jonulak jonulak approved these changes

@jeromehardaway jeromehardaway Awaiting requested review from jeromehardaway

Assignees

@Sfayson1 Sfayson1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Logging
3 participants
@Sfayson1 @jeromehardaway @jonulak