Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to solve some flakiness on integration tests #131

Closed
wants to merge 6 commits into from

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Nov 27, 2024

PR Type

Fix

Short Description

Clickup Ticket(s): NA

Integration tests are hanging at random. Adding debug logs here to try to identify why.

Tests Added

NA

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.20%. Comparing base (3cc970e) to head (b58cfab).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #131      +/-   ##
==========================================
+ Coverage   89.74%   94.20%   +4.46%     
==========================================
  Files          23       23              
  Lines        2107     2107              
  Branches      177      177              
==========================================
+ Hits         1891     1985      +94     
+ Misses        216      122      -94     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lotif
Copy link
Collaborator Author

lotif commented Nov 27, 2024

This has to do with background tasks. They will go away on #122 so it's not worth fixing it.

@lotif lotif closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants