Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Part 1] Display logs for client and server #128

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[Part 1] Display logs for client and server #128

wants to merge 9 commits into from

Conversation

lotif
Copy link
Collaborator

@lotif lotif commented Nov 25, 2024

PR Type

Feature

Short Description

Clickup Ticket(s): https://app.clickup.com/t/8689qq767

I'm splitting this ticket into 2 PRs: one for back end and one for front end.

This is the back end one, where I am making 2 endpoints to retrieve the logs for the server and the clients of a job.

In order to make it possible, I had to add the location of the log paths in the filesystem to the database. The log file paths had to be returned from the functions that start both clients and servers, and also the client endpoint that starts a client. That approach may not work when we move this to slurm jobs, but we'll cross that bridge when we get there.

Tests Added

Fully unit and integration tested

florist/api/client.py Dismissed Show dismissed Hide dismissed
florist/api/routes/server/job.py Dismissed Show dismissed Hide dismissed
florist/api/routes/server/job.py Dismissed Show dismissed Hide dismissed
florist/api/routes/server/job.py Dismissed Show dismissed Hide dismissed
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 93.10345% with 4 lines in your changes missing coverage. Please review.

Project coverage is 94.16%. Comparing base (43f5c6e) to head (3859f10).

Files with missing lines Patch % Lines
florist/api/routes/server/job.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   94.20%   94.16%   -0.05%     
==========================================
  Files          23       23              
  Lines        2107     2158      +51     
  Branches      177      177              
==========================================
+ Hits         1985     2032      +47     
- Misses        122      126       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants