Shader name Standard (Roughness Setup) should be Autodesk Interactive in StandardsToHDLitMaterialUpgrader
#7829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`UpgradeStandardShaderMaterials.cs`
| @@ -12,7 +12,7 @@ static List<MaterialUpgrader> GetHDUpgraders() | |||
| var upgraders = new List<MaterialUpgrader>(); | |||
| upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard", "HDRP/Lit")); | |||
| upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard (Specular setup)", "HDRP/Lit")); | |||
| upgraders.Add(new StandardsToHDLitMaterialUpgrader("Standard (Roughness setup)", "HDRP/Lit")); | |||
| upgraders.Add(new StandardsToHDLitMaterialUpgrader("Autodesk Interactive", "HDRP/Lit")); | |||
There was a problem hiding this comment.
Hey @RemyUnity could you confirm this? And also I think we need to update Standard (Specular setup)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read the Contributing guide before making a PR.
Checklist for PR maker
need-backport-*label. After you backport the PR, the label changes tobackported-*.CHANGELOG.mdfile.Purpose of this PR
Why is this PR needed, what hard problem is it solving/fixing?
Grab some
Autodesk Interactivematerials. Click in the wizard window 'Convert selected built-in materials to HDRP'. Nothing happens.Testing status
Describe what manual/automated tests were performed for this PR
After modifying this shader name, the materials get converted correctly.
Comments to reviewers
Notes for the reviewers you have assigned.
I don't know how am I supposed to add a backport label.