Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use assertSame instead of deepEquals if actual is a mock #2641

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Use assertSame instead of deepEquals if actual is a mock #2641

merged 3 commits into from
Oct 4, 2023

Conversation

EgorkaKulikov
Copy link
Collaborator

Description

Fixes # (2639)

How to test

Automated tests: utbot-samples pipeline as a set of regression checks
Manual tests: scenario from issue

Self-check list

  • I've set the proper labels for my PR (at least, for category and component).
  • PR title and description are clear and intelligible.
  • I've added enough comments to my code, particularly in hard-to-understand areas.
  • The functionality I've repaired, changed or added is covered with automated tests.
  • Manual tests have been provided optionally.
  • The documentation for the functionality I've been working on is up-to-date.

@EgorkaKulikov EgorkaKulikov added comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug labels Oct 3, 2023
@EgorkaKulikov EgorkaKulikov linked an issue Oct 3, 2023 that may be closed by this pull request
Incorrect assertNull is applied to the value returned from a mocked method #2639
Closed
IlyaMuravjov
IlyaMuravjov approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@IlyaMuravjov IlyaMuravjov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

...ework/src/main/kotlin/org/utbot/framework/codegen/services/framework/TestFrameworkManager.kt Show resolved Hide resolved
Damtev
Damtev approved these changes Oct 4, 2023
View reviewed changes
Copy link
Member

@Damtev Damtev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alisevych alisevych merged commit 09aebe1 into main Oct 4, 2023
38 checks passed
@alisevych alisevych deleted the egor/assertsame_for_mocks branch October 4, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IlyaMuravjov IlyaMuravjov IlyaMuravjov approved these changes

@Damtev Damtev Damtev approved these changes

Assignees
No one assigned
Labels
comp-codegen Issue is related to code generator ctg-bug-fix PR is fixing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect assertNull is applied to the value returned from a mocked method
4 participants
@EgorkaKulikov @Damtev @IlyaMuravjov @alisevych