audit(14): arbitrum block number #280
Conversation
| } | ||
| } | ||
|
|
||
| contract NonlinearDutchDecayLibTest is Test, GasSnapshot { | ||
| contract NonlinearDutchDecayLibTest is Test, GasSnapshot, BlockNumberish { |
There was a problem hiding this comment.
Wondering if we should do another test suite for chainId 42161 that uses setBlockNumber since our current tests just use vm.roll() which wouldn't do anything in an Arbitrum environment
There was a problem hiding this comment.
Ahh yeah so imo the NonLinearDutchDecayLib should function completely agnostic of the behavior of BlockNumberish - since it strictly takes it in as a parameter. So a test that the blockNumberish parameter passed into the Lib is correctly set may be better in the reactor test
| /** | ||
| * @notice Minimal interface for interacting with Arbitrum system contracts | ||
| */ | ||
| interface IArbSys { |
There was a problem hiding this comment.
We can add this as a submodule:
[submodule "lib/nitro-contracts"]
path = lib/nitro-contracts
url = https://github.com/OffchainLabs/nitro-contracts
There was a problem hiding this comment.
Agree but not sure if necessary since we also don't need the entire IArbSys interface, just this one func
fix #283