Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-pars that are global should elevate to gsplot() #366

Closed
lindsayplatt opened this issue Jun 30, 2016 · 10 comments
Closed

non-pars that are global should elevate to gsplot() #366

lindsayplatt opened this issue Jun 30, 2016 · 10 comments
Assignees
Milestone

Comments

@lindsayplatt
Copy link

e.g. frame.plot, asp

gs <- gsplot(frame.plot=FALSE)
#instead of 
gs <- gsplot() %>% points(1,1,frame.plot=FALSE)
@lindsayplatt
Copy link
Author

lindsayplatt commented Jun 30, 2016

@jread-usgs

global.par
global.config
view.par
view.config

or instead it gets funneled to the function that actually uses it (@jiwalker-usgs)

@lindsayplatt
Copy link
Author

add frame.plot to global.only.par in modify_par.R

@lindsayplatt lindsayplatt added this to the 0.8.0 milestone Oct 24, 2016
@lindsayplatt
Copy link
Author

@ldecicco-USGS get list (7 args) and cross ref to what's in global now

@lindsayplatt
Copy link
Author

asp is tricky - try to get it to match base

@ldecicco-USGS
Copy link
Member

https://svn.r-project.org/R/trunk/src/library/graphics/R/plot.R

plot.default <-
    function(x, y = NULL, type = "p", xlim = NULL, ylim = NULL,
             log = "", main = NULL, sub = NULL, xlab = NULL, ylab = NULL,
             ann = par("ann"), axes = TRUE, frame.plot = axes,
             panel.first = NULL, panel.last = NULL, asp = NA, ...)

So....axes, frame.plot, panel.first,panel.last, and asp?

@ldecicco-USGS
Copy link
Member

ldecicco-USGS commented Feb 3, 2017

main
sub
axes works within view()
asp? see #367 dealing with this at a later date
xlab needs to be called within a side call
ylab needs to be called within a side call

@lindsayplatt
Copy link
Author

asp needs to affect the view

@lindsayplatt lindsayplatt self-assigned this Feb 3, 2017
@jordansread
Copy link
Member

I think ylab and clan should stay on sides, right?

@jordansread
Copy link
Member

Autocorrect! xlab

@ldecicco-USGS
Copy link
Member

I think we're talking about 2 different things. Yes, ylab and clan :) should go to sides. But, I was listing the things that should be allowed/accounted for when initiating the gsplot object. ie... the arguments that are in plot.default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants