Aggregate map fix

[JulianWielga]

Summary by CodeRabbit

• New Features

  • Enhanced token definitions and parsing logic in the AggMapLikeParser for better handling of input formats.
  • Introduced unit tests for the AggMapLikeParser class to validate parsing methods.
  • Added environment constants and a logging function to improve debugging in development.

• Bug Fixes

  • Improved user experience by optimizing scroll behavior in the AceWithSettings component.

• Chores

  • Updated dependency version for chevrotain to enhance compatibility.

[github-actions]

created: #7309
⚠️ Be careful! Snapshot changes are not necessarily the cause of the error. Check the logs.

[JulianWielga]

@coderabbitai summary

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces several changes across multiple files in the nussknacker-designer-client project. The package.json file is updated to change the version of the chevrotain dependency from 11.0.3 to 10.5.0. In the PanZoomPlugin.ts file, a new import for isVisualTesting is added, and the fitContent method is modified to conditionally apply transitions based on this value. The aggMapLikeParser.tsx file sees significant refactoring, including the addition of new tokens and parsing methods, enhancing the lexer capabilities and restructuring the parsing logic. A new test file parser.test.ts is introduced to validate the parsing functionalities of the AggMapLikeParser. The useAggParamsSerializer.tsx file simplifies the deserialization logic by removing the lexer and directly utilizing the parser methods. The AceWithSettings.tsx component is updated to prevent unnecessary scrolling when the editor is not focused. The DEV_TOOLBARS.ts file is modified to import the isDev constant instead of declaring it locally, while the devHelpers.ts file adds new constants and a logging function to facilitate debugging.

Possibly related PRs

• Scale fields in components #7213: This PR updates the package.json file to modify the version of several Material-UI dependencies, which is related to the main PR's change of the chevrotain dependency version in the same file.
• Revert "Scale fields in components (#7213)" #7253: This PR reverts the changes made in PR Scale fields in components #7213, indicating a direct relationship as it involves the same package.json file and the same dependencies.
• Scale name in components fixed #7258: This PR is a follow-up to PR Scale fields in components #7213, addressing issues related to the display and testing of components that also involve changes to the package.json file, thus maintaining a connection to the main PR.

Suggested labels

submodules

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b0a4c62 and ea52790.

⛔ Files ignored due to path filters (1)

• designer/client/package-lock.json is excluded by !**/package-lock.json

📒 Files selected for processing (8)

• designer/client/package.json (1 hunks)
• designer/client/src/components/graph/PanZoomPlugin.ts (1 hunks)
• designer/client/src/components/graph/node-modal/aggregate/aggMapLikeParser.tsx (3 hunks)
• designer/client/src/components/graph/node-modal/aggregate/parser.test.ts (1 hunks)
• designer/client/src/components/graph/node-modal/aggregate/useAggParamsSerializer.tsx (2 hunks)
• designer/client/src/components/graph/node-modal/editors/expression/AceWithSettings.tsx (1 hunks)
• designer/client/src/components/toolbarSettings/DEV_TOOLBARS.ts (1 hunks)
• designer/client/src/devHelpers.ts (1 hunks)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Dzuming]

LGTM

[lciolecki]

This should be released in 1.18.3, WDYT?