-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable the collection of test of a directory tree #657
base: master
Are you sure you want to change the base?
Conversation
I'm not clear on what this update is building? The |
AFAIK the |
This would be super useful, I was looking for this exact functionality. I have some tests in C and some in C++ and it seems the easiest way to run them both would be to link one test runner against them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flieger19 I gave this a try, I think it's a great start. To be complete I think it should have the following:
- The usage/help text needs to be updated to let the user know it takes directories as input instead of just files.
- Add some unit tests. This gives usage examples "for free" and builds confidence. The last thing we want is the runner generator to drop tests. Looks like
test_generate_test_runner.rb
would be a good place to start, I'm sure @mvandervoord would know more (I'm not a dev here). - To keep compatibility with how the script handles files right now, it'd be better if it placed all the tests into one runner file. e.g. I tried it with
test.c
andtest_cpp.cpp
and it gave me three output files:test_Runner.c
,test_cpp_Runner.cpp
,testAll_Runner.c
. It would be better if it gave me justtestAll_Runner.c
(or make the name of the output file mandatory so it doesn't have to make up a name). This might also make it easier to integrate withtest_generate_test_runner.rb
for unit tests.
Hi. I also need this feature. @flieger19 would it be possible to address the notes that @tango-taylor raised, so this can get merged? Thanks for your work so far! |
No description provided.