Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cppcheck plugin #764

Open
wants to merge 9 commits into
base: test/ceedling_0_32_rc
Choose a base branch
from

Conversation

deltalejo
Copy link

@deltalejo deltalejo commented Apr 27, 2023

I made a plugin to run Cppcheck analysis as Ceedling tasks.
I think it is a very useful plugin that promotes using static anlysis tools for embedded software development.
I'm open to feedback.

@mvandervoord
Copy link
Member

@deltalejo -- thanks for working on this! I am very happy to see this feature added and I appreciate your work!

@mvandervoord
Copy link
Member

You are welcome to host this plugin yourself, as you have it now. If at any point you decide you'd rather have it part of the main Ceedling project, we can do that too. I don't want to take credit for your work or anything (we should find a way to give good credit for submitted plugins. Certainly in the plugin readme... maybe something else too?). I'm just interested in making it easy for people to install, etc.

@deltalejo
Copy link
Author

It would be great if the plugin gets included in Ceedling, just let me know how to proceed.
I can add an AUTHORS file to plugin sources if that's OK.

@tyler-macinnis
Copy link

Having interacted with @deltalejo before on a different plugin, I would love for the Cppcheck plugin to be added into Ceedling. I'm already using it regularly and it's fantastic. Definitely should find a way to acknowledge authors/contributors. Here's some ideas that come to mind:

  • Maintaining a section in the README listing all contributors along with their contributions. This can be manually updated or automated using tools like all-contributors.
  • Creating a separate CONTRIBUTORS.md file that lists all the contributors and their contributors. Could be linked from the README for visibility. This could be placed in the docs folder.
  • Once v0.32 is released, maybe including a section in the release notes that credits contributors for their work?

@mkarlesky
Copy link
Member

@tyler-macinnis We're making progress on recognizing contributors appropriately. The new ReleaseNotes.md in docs/ has a significant section towards the top attempting to do so as a first step. Your other suggestions are good ones. We're motivated to clean up and better structure processes and documentation. As we continue to do so, we'll be sure to give some attention to recognizing and documenting contributors.

@mkarlesky
Copy link
Member

@deltalejo A good static analysis plugin is a great addition to the project. We probably won't be able to incorporate it into the next significant release, but I'd like to at minimum slate this for the next point release. We are transitioning to packaging and final release work, including much improved Docker images for Ceedling and plugin tools. I'll make sure we're in a good place for adding Cppcheck to the Docker images for future updates.

@deltalejo
Copy link
Author

deltalejo commented Jun 25, 2024

@mkarlesky
I'm always glad to contribute to this awesome project. Let me know if you have in mind some steps you want me to take on this plugin so it is included in a near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants