-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ts302 #826
base: master
Are you sure you want to change the base?
Create ts302 #826
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be a javascript (.js) file as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good! My colleague @Jaime-Trinidad will review it further. If you could in the meantime sign the CLA on both of your PRs that'd be great.
Hi @Charles-Milesight everything is good, please sign the CLA |
Hi @Charles-Milesight please sign the CLA so I can merge this PR |
Summary
...
Changes
Checklist for Reviewers
profileIDs
should not bevendorID
and should be a unique value for every profile.index.yaml
file.Notes for Reviewers
...
Release Notes