Added a download status #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLartians
approved these changes
May 22, 2023
There was a problem hiding this comment.
Thanks for the PR, the status and checksum checks are definitely a welcome improvement!
Unfortunately they would need to be updated for each new version of CPM.cmake. It actually would be awesome to update the "official" get_cpm.cmake script (with values filled in in the publish GitHub workflow) to include the checksum as well!
|
@schtobia the code style status check is failing. Could you run the code formatter and update the PR? |
You're absolutely right. I will work on this, but have no ETA. |
This is very useful in shaky network solutions. We want both a success and a failure message, to determine if the download was successful.
This is more comprehensive than just comparing against an empty file.
TheLartians
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR would a download status for and a more comprehensive compare against a given checksum for CPM.
Additionally, the versions of the pulled libraries is bumped.