Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cipher/polybius): add fuzz test to polybius cipher #600

Merged
merged 4 commits into from
Nov 11, 2022
Merged

feat(cipher/polybius): add fuzz test to polybius cipher #600

merged 4 commits into from
Nov 11, 2022

Conversation

mcaci
Copy link
Contributor

@mcaci mcaci commented Oct 31, 2022

Hi again, I keep adding fuzz tests for #480, this time for Polybius. I tested it with go test ./cipher/polybius/ to test the corpus and go test -fuzz=FuzzPoly ./cipher/polybius/ to run the fuzzer itself.
If that Is that ok for you to add it let me know. Also if you have any feedbacks about my change let me know so that I can adapt it.
You will see that I did some changes to the errors and restrict some more the possible inputs to the algorithm based a bit on the description of the algorithm in the wikipedia page mentioned at the beginning of the polybius file.
Thanks again for your work!

cipher/polybius/polybius.go Outdated Show resolved Hide resolved
@mcaci
Copy link
Contributor Author

mcaci commented Nov 9, 2022

I have resolved the conversation after the approvals

@tjgurwara99
Copy link
Member

@raklaptudirm @siriak I think there is something wrong with my permissions. I'm unable to squash and merge the PR - are you both able to do this?

@raklaptudirm
Copy link
Member

@tjgurwara99 Looks like the base branch was out of date so merging was blocked.

@raklaptudirm raklaptudirm merged commit 7523f41 into TheAlgorithms:master Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants