Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(cipher/rsa): add fuzz test to rsa cipher #591

Merged
merged 4 commits into from
Oct 31, 2022
Merged

tests(cipher/rsa): add fuzz test to rsa cipher #591

merged 4 commits into from
Oct 31, 2022

Conversation

mcaci
Copy link
Contributor

@mcaci mcaci commented Oct 24, 2022

Hi, in the context of #480 I'm adding the fuzz tests for the rsa algorithm. I tested it with go test ./cipher/rsa/ to test the corpus and go test -fuzz=FuzzRsa ./cipher/rsa/ to run the fuzzer itself.
If that Is that ok for you to add it let me know. Also if you have any feedbacks about my change let me know so that I can adapt it.
Thanks!

@mcaci mcaci changed the title Rsa fuzz feat(cipher/rsa): add fuzz test to rsa cipher Oct 25, 2022
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
cipher/rsa/rsa_test.go Outdated Show resolved Hide resolved
@mcaci
Copy link
Contributor Author

mcaci commented Oct 25, 2022

Hi @tjgurwara99, I pushed all the changes you suggested me, thanks for all your feedbacks, especially the t.Helper() I have just learned about it. Let me know if you have other feedbacks and if I properly addressed the comments from the conversations you shared with me. Thanks again!

@raklaptudirm raklaptudirm changed the title feat(cipher/rsa): add fuzz test to rsa cipher tests(cipher/rsa): add fuzz test to rsa cipher Oct 31, 2022
@raklaptudirm raklaptudirm merged commit 1d2c054 into TheAlgorithms:master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants