Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/unittest/CMakeLists.txt: balance if()/endif() guards #2276

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

trofi
Copy link

@trofi trofi commented May 4, 2024

Without the change cmake warns about mismatching guards as:

CMake Warning (dev) in test/unittest/CMakeLists.txt:
  A logical block opening on the line
    /build/rapidjson/test/unittest/CMakeLists.txt:83 (if)
  closes on the line
    /build/rapidjson/test/unittest/CMakeLists.txt:95 (endif)
  with mis-matching arguments.

Without the change `cmake` warns about mismatching guards as:

    CMake Warning (dev) in test/unittest/CMakeLists.txt:
      A logical block opening on the line
        /build/rapidjson/test/unittest/CMakeLists.txt:83 (if)
      closes on the line
        /build/rapidjson/test/unittest/CMakeLists.txt:95 (endif)
      with mis-matching arguments.
@tencent-adm
Copy link
Member

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants