Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added random sort #2409

Closed

Conversation

stokedcheetah
Copy link

Literally just adds a little piece of code for random sorting.

Copy link
Member

@FireMasterK FireMasterK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the translation string and fix the lint issues.

Also, sorting functionality is likely going to be removed entirely with #2353

@Bnyro
Copy link
Member

Bnyro commented May 16, 2023

Or sorting gets implemented on the backend side instead of entirely dropping it ;-).

@FireMasterK
Copy link
Member

Or sorting gets implemented on the backend side instead of entirely dropping it ;-).

The problem is that we require a way to index videos in such orders. When we have time, it's simple as we can just look for videos older than the last time value.

When it's text, I'm just not sure what we can do!

I am trying to avoid a LIMIT and OFFSET in a SQL statement, since that's actually an inefficient way to do pagination.

@stokedcheetah
Copy link
Author

I fixed it

@FireMasterK
Copy link
Member

You still have to add the translation string: actions.random

@Bnyro
Copy link
Member

Bnyro commented Dec 19, 2023

Closing due to inactivity.

@Bnyro Bnyro closed this Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants