Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: display "--" as placeholder when total rewards api call fails #1215

Merged
merged 3 commits into from
Dec 2, 2024
Merged

refactor: display "--" as placeholder when total rewards api call fails #1215

merged 3 commits into from
Dec 2, 2024

Conversation

UrbanWill
Copy link
Contributor

Description

  • Refactor useTotalRewards hook to return error if api call fails
  • Refactor UI to display "--" in Total rewards table cell when data is unavailable

🖼️ Screenshots:

Screenshot 2024-11-29 at 14 26 52

@UrbanWill UrbanWill temporarily deployed to talisman-ui (Preview) November 29, 2024 07:32 — with GitHub Actions Inactive
@UrbanWill UrbanWill temporarily deployed to portal-storybook (Preview) November 29, 2024 07:32 — with GitHub Actions Inactive
chidg
chidg approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UrbanWill UrbanWill merged commit ed8225b into main Dec 2, 2024
9 checks passed
@UrbanWill UrbanWill deleted the refactor/total-rewards-placeholder branch December 2, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

@alecdwm alecdwm Awaiting requested review from alecdwm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UrbanWill @chidg