Implement auto-mute to improve uncomfortable audio distortion while host is lagging #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he app when minimized
…e when it is unfocused
…in sound settings
…fault values for the fps threshold
YoshiRulz
requested changes
Mar 10, 2024
| @@ -28,330 +28,409 @@ protected override void Dispose(bool disposing) | |||
| /// </summary> | |||
| private void InitializeComponent() | |||
| { | |||
| this.Cancel = new System.Windows.Forms.Button(); | |||
There was a problem hiding this comment.
Sorry you had to deal with the Designer. If this feature is accepted, I'll rewrite this in a declarative style, then you can rebase and have a smaller diff.
YoshiRulz
reviewed
Mar 11, 2024
|
|
||
| // Mutes the game if the current FPS reaches the threshold chosen by the user or lower | ||
| // An option in the sound settings needs to be turned on for this to work. | ||
| if (Config.MuteOnLag && _lastFps <= PlatformFrameRates.GetFrameRate(Emulator.SystemId, Emulator.HasRegions() && Emulator.AsRegionable().Region is DisplayType.PAL) * ((double)Config.FPSThresholdPercentage / 100)) |
There was a problem hiding this comment.
PlatformFrameRates are not intended to query the actual core's framerate per se (they are rather "political numbers"). The core's IVideoProvider provides this kind of information and should be used.
YoshiRulz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3238
DISCLAIMER : I have done this for a school project. I'm not going to think this is going to be accepted at all, but if you could leave some comments I would be grateful.
Added 2 settings in the Sound Settings menu for muting the app in certain circumstances.
The first one is to mute the app when in the background or unfocused and can be toggled on and off.
The second on is to mute the app when the FPS reaches a threshold chosen by the user (by default 56). It can be toggled on and off and the threshold can also be modified in the settings.
Check if completed: