Prior value now returned as double

[evgueni-ovtchinnikov]

Changes in this pull request

Testing performed

Related issues

fixes #1290

Checklist before requesting a review

• I have performed a self-review of my code
• I have added docstrings/doxygen in line with the guidance in the developer guide
• I have implemented unit tests that cover any new or modified functionality
• The code builds and runs on my machine
• CHANGES.md has been updated with any functionality change

Contribution Notes

Please read and adhere to the contribution guidelines.

Please tick the following:

• The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in SIRF (the Work) under the terms and conditions of the Apache-2.0 License.

[KrisThielemans]

great. Please update CHANGES.md.

Please confirm we're already using double for the log-likelihood.

[evgueni-ovtchinnikov]

CHANGES.md updated, log-likelihoods return neither float nor double.

[KrisThielemans]

log-likelihoods return neither float nor double.

That makes no sense, I'm afraid. In fact, I'm relatively sure you fixed float-to-double a few months ago

[evgueni-ovtchinnikov]

log-likelihoods return neither float nor double.

I was briefly referring to log-likelihoods specifically, the full answer should have been: the base class does return the objective function value as double, and the methods that compute it are not overridden by the derived log-likelihoods classes in stir_x.h.