Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #110
Note: I was looking for a reason to add code into ResetPasswordBundle to facilitate multiple users, and I couldn't really find a solid reason why we need more code to make that happen. The solution I came up with is to support multiple entity relations in the
ResetPasswordRequest
entity (userland). This is where theResetPasswordHelper
(bundle) grabs the user object from to begin with, after all, the bundle really doesn't care what the user object is, so long that it is andobject
.As the
ResetPasswordRequest
object is creating withmake:reset-password
or by the user directly - the only code change we need to make is over in MakerBundle. I'm still on the fence as to the best way to handle multiple users without adding too much complexity to and already complexmake:reset-password