Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] how-to multiple entities #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Apr 28, 2024

  • add section "header" to the readme to explain what we're actually doing and why...
  • PR in MakerBundle to handle multiple users.

fixes #110

Note: I was looking for a reason to add code into ResetPasswordBundle to facilitate multiple users, and I couldn't really find a solid reason why we need more code to make that happen. The solution I came up with is to support multiple entity relations in the ResetPasswordRequest entity (userland). This is where the ResetPasswordHelper (bundle) grabs the user object from to begin with, after all, the bundle really doesn't care what the user object is, so long that it is and object.

As the ResetPasswordRequest object is creating with make:reset-password or by the user directly - the only code change we need to make is over in MakerBundle. I'm still on the fence as to the best way to handle multiple users without adding too much complexity to and already complex make:reset-password

@jrushlow
Copy link
Collaborator Author

I should note - I would expect that the vast majority of projects have a single User entity, there are many that probably have 2 "user"-ish entities, anymore than 2 - you're beyond the scope of what either this bundle or MakerBundle are willing to handle (in terms of "generated code"). While it is possible to use this bundle for more than 2 entities - I don't see a make:reset-password --entity-count=6 anytime soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Minor Minor Enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple entities
1 participant