Color Clipboard #3100
Open
Color Clipboard #3100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vankata453
reviewed
Nov 15, 2024
Vankata453
reviewed
Nov 15, 2024
|
What is this? Please describe this feature in the pr description. |
Frostwithasideofsalt
approved these changes
Nov 16, 2024
MatusGuy
reviewed
Nov 16, 2024
There was a problem hiding this comment.
Does this copy to an in-game clipboard or the system clipboard? This feature might be confusing for users who want to copy/paste a color to outside of supertux.
You could parse a hex color value from the system clipboard which in my opinion would provide a better experience.
You can use SDL's clipboard functionality to do this.
|
I can do that, sure. I'm still gonna keep the current in game functionality, but I'm gonna also add parsing it from the clipboard upon clicking the paste entry. |
MatusGuy
reviewed
Nov 17, 2024
Vankata453
reviewed
Nov 19, 2024
MatusGuy
reviewed
Nov 19, 2024
[ci skip]
MatusGuy
reviewed
Nov 23, 2024
Co-authored-by: Marty <[email protected]>
MatusGuy
approved these changes
Nov 30, 2024
tobbi
reviewed
Nov 30, 2024
| @@ -22,7 +22,7 @@ | |||
| class ItemAction final : public MenuItem | |||
| { | |||
| public: | |||
| ItemAction(const std::string& text, int id = -1, std::function<void()> callback = {}); | |||
| ItemAction(const std::string& text, int id = -1, std::function<void()> callback = {}, const Color& text_color = Color(1.f, 1.f, 1.f)); | |||
There was a problem hiding this comment.
Don't we have a Color::WHITE constant somewhere?
tobbi
reviewed
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new options to the Color Menu:
These options enable users to copy and paste colors between objects with the color menu via the SDL's clipboard feature.