Large refactor + port client to TS + sidebar article div #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozxybox
force-pushed
the
feat/sidebar-article-div
branch
from
23bfe17 to
e3610b1
Compare
JoLoZ
requested changes
Jan 6, 2024
ozxybox
force-pushed
the
feat/sidebar-article-div
branch
from
057f5d8 to
6d2defe
Compare
tsa96
approved these changes
Jan 11, 2024
JoLoZ
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fairly large refactor. I ported the client code to TS and tried to reduce as much state being shared across exporter as possible. I also added a div for articles so we can add a collapse button later