Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Exporting screenshots at resolutions higher than current game resolution makes water display incorrectly #1268

Open
pivotman319-owo opened this issue Dec 7, 2024 · 0 comments
Open

Bug: Exporting screenshots at resolutions higher than current game resolution makes water display incorrectly #1268

pivotman319-owo opened this issue Dec 7, 2024 · 0 comments
Labels
Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. Type: Bug This is a problem with something that should be working one way, but isn't. What: Graphics Graphics-related stuff

Comments

@pivotman319-owo
Copy link
Member

pivotman319-owo commented Dec 7, 2024 •
edited
Loading

Describe the bug

Taking screenshots using the png command at a viewport resolution that is higher than the game's current screen resolution will cause projected water refractions to vertically scale incorrectly throughout the entire framebuffer.

Exporting at 1920x1080px (native resolution):
Water displaying correctly when exported at current game resolution

Exporting at 3840x2160px (2x native resolution):
Water refraction vertically displaying incorrectly at 2x export resolution

To Reproduce

  1. Launch game with -w 1920 -h 1080
  2. Launch any map with water; the base Portal 2 maps from a1-a3 have plenty of reflective water
  3. Move and look directly at a water surface
  4. Spew current ingame framebuffer by invoking png 3840 2160 test
  5. Check the spewed framebuffer in mod screenshots directory

Issue Map

N/A

Expected Behavior

Water should be displaying correctly at higher export resolutions

Operating System

Not Applicable
@pivotman319-owo pivotman319-owo added Type: Bug This is a problem with something that should be working one way, but isn't. What: Graphics Graphics-related stuff Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. labels Dec 7, 2024
@pivotman319-owo pivotman319-owo changed the title Bug: Exporting screenshots at resolutions higher than current game resolution makes water display incorrectly Bug: Exporting screenshots at resolutions higher than current game resolution makes water and props display incorrectly Dec 7, 2024
@pivotman319-owo pivotman319-owo changed the title Bug: Exporting screenshots at resolutions higher than current game resolution makes water and props display incorrectly Bug: Exporting screenshots at resolutions higher than current game resolution makes water display incorrectly Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority 3: Medium Something that should be attempted/looked at for the next release, and done if possible. Size 3: Medium Something that will take a couple days to a week to do. Type: Bug This is a problem with something that should be working one way, but isn't. What: Graphics Graphics-related stuff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pivotman319-owo