Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add planar reflections to PBR shader #1257

Open
TheEnderek0 opened this issue Nov 23, 2024 · 0 comments
Open

Enhancement: Add planar reflections to PBR shader #1257

TheEnderek0 opened this issue Nov 23, 2024 · 0 comments
Labels
Type: Enhancement This is something that improves upon an already existing thing.

Comments

@TheEnderek0
Copy link

What would this enhancement be for?

Rendering

Describe your enhancement suggestion in more detail

Planar reflections are already possible in LightmappedReflective
These basically re-render the world again, like in the Water shader. This would be extremely useful for areas that require these high quality reflections, like a window in a lit room. However, it would also require to increase the limit of allowed re-renders (cameras) active at a time, as currently only one (not including Portals) is allowed, hence if you try to use two LightmappedReflective materials only one of them is going to work properly.

Additionally, there could a way to disable specific brushes via a proxy of some sorts, like material_modify_control but for a specific brush only, or in general not re-rendering the world if the surface is not visible. This would decrease the performance impact if used carefully.

@TheEnderek0 TheEnderek0 added the Type: Enhancement This is something that improves upon an already existing thing. label Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement This is something that improves upon an already existing thing.
Projects
None yet
Development

No branches or pull requests

1 participant