Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Implement dedicated builder and binder for CallIfBlock and PipeIfBlock #33

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 8, 2024

Original issue description

Tell us about your idea

Currently conditional and non-conditional Pipe and Call blocks are handled by the same builder and binder. Break this out so that we have:

  • CallBlockBuilder, CallBlockBinder
  • CallIfBlockBuilder, CallIfBlockBinder
  • PipeBlockBuilder, PipeBlockBinder
  • PipeIfBlockBuilder, PipeIfBlockBinder

Anything else?

No response

closes #32

@github-actions github-actions bot added the feature Improvements or additions to documentation label Aug 8, 2024
@bfarmer67 bfarmer67 marked this pull request as ready for review August 8, 2024 19:17
@bfarmer67 bfarmer67 merged commit e5a01f2 into develop Aug 8, 2024
@bfarmer67 bfarmer67 deleted the feature/32-feature-implement-dedicated-builder-and-binder-for-callifblock-and-pipeifblock branch August 8, 2024 19:18
bfarmer67 added a commit that referenced this pull request Aug 9, 2024
* [FEATURE]: Binder base (#31)

* Implement abstract binders
* Refactor existing binders to use abstract base

---------

Co-authored-by: Brenton Farmer <[email protected]>

* [FEATURE]: Implement dedicated builder and binder for CallIfBlock and PipeIfBlock (#33)
* Factor CallIfBlock* and PipeIfBlock* into their own builders and binders.

---------

Co-authored-by: Brenton Farmer <[email protected]>

* [FEATURE]: Improve builder pattern (#35)
* Refactor builders to eliminate reliance on partial interfaces and classes

---------

Co-authored-by: Brenton Farmer <[email protected]>

* Fix footer
* Previous version was 'v1.1.6'. Version now 'v1.2.0'.

---------

Co-authored-by: Brenton Farmer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant