Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(centraldashboard): ad i18n #6022

Closed

Conversation

JessicaBarh
Copy link
Contributor

@JessicaBarh JessicaBarh commented Jun 28, 2021

This PR implements internationalization to the centraldashboard
Resolves StatCan#57

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 28, 2021
@aws-kf-ci-bot
Copy link

Hi @JessicaBarh. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign elikatsis after the PR has been reviewed.
You can assign the PR to them by writing /assign @elikatsis in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wg102
Copy link
Contributor

wg102 commented Jun 28, 2021

@googlebot I consent.

@JessicaBarh
Copy link
Contributor Author

For the i18n of centraldashboard there's really two ways we can do this. The way we are currently implementing it is using one large json file (languages.json) that includes all the translated text for each object for every language - currently containing en and fr. The other way would be to have a separate json file for each language, this one would require a little refactoring to the current branch.

If there is a preferred way that should be followed for consistency, please share your thoughts!

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale label Jan 3, 2022
@stale stale bot closed this Mar 2, 2022
@wg102 wg102 deleted the upstream-i18n-centraldashboard branch December 13, 2022 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement i18n for Central Dashboard Upstream
4 participants