Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Epic] Pushing features upstream - Centraldashboard #54

Open
3 tasks
saffaalvi opened this issue Apr 13, 2021 · 3 comments
Open
3 tasks

[Epic] Pushing features upstream - Centraldashboard #54

saffaalvi opened this issue Apr 13, 2021 · 3 comments
Labels
component/kubeflow kind/epic Tracks related issues; has no size

Comments

@saffaalvi
Copy link

saffaalvi commented Apr 13, 2021

After the Jupyter Web App features have been pushed upstream (progress being tracked in this EPIC #45), we will need to move onto pushing our centrealdashboard changes upstream as well.

Changes made up until v1.2 have been documented in this issue: #33. We will need to narrow down this list and decide which features and customizations we want to push upstream.

The process for pushing the centraldashboard changes upstream might be different than how we pushed our Jupyter Web App changes upstream. Since the Jupyter Web App component was basically re-written to be part of crud-web-apps and our jupyter-web-app component was in a different repo, jupyter-apis, we had to go the manual route to push everything upstream.

The centraldashboard component has not gone through such a major change and is still part of the same repo, so it might be possible to do a simple merge to push our features from this component upstream. We did first attempt to merge jupyter-apis into crud-web-apps/jupyter and this process was documented in this issue #44, which can be referred to if trying a merge for the centraldashboard component.

This issue can later be converted into an EPIC like the Jupyter Web App one if it isn't just a simple merge and instead, there's a need to track individual issues and features.

Something to be noted is that it's important to start off with figuring out how to get a local development of the centraldashboard component upstream running so that changes can be tested before pushing anything.

The items to push are:

@saffaalvi
Copy link
Author

It might be helpful to look at the steps of how we did the rebase to v1.2 as well. In that case, we brought in all of upstream's commits into our repo. This time, we want to do the opposite and bring our commits into upstream.
#34 (comment)

@wg102
Copy link

wg102 commented May 13, 2021

The list of things to push upstream would be : (WIP)

  • fonts as assets part of the service -> compare to jupyter-apis
  • Fix the cards (?)
  • Manage multiple profiles
  • Official Languages

@wg102 wg102 added the kind/epic Tracks related issues; has no size label Jun 16, 2021
@wg102 wg102 changed the title Pushing features upstream - Centraldashboard [Epic] Pushing features upstream - Centraldashboard Jun 16, 2021
@kanna823
Copy link

when would the above epic be resolved and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/kubeflow kind/epic Tracks related issues; has no size
Projects
None yet
Development

No branches or pull requests

3 participants