feat(istio/kubeflow-gateway): update all configs to reference CNP kubeflow gateway. #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justbert
requested review from
rochris-daaas and
a team
and removed request for
rochris-daaas
frazs
approved these changes
Mar 15, 2023
justbert
commented
Mar 16, 2023
vexingly
approved these changes
Mar 16, 2023
@vexingly - Yeah, there are a few! :) My methodology was just to generate the manifest and look for any configs that referenced the centralized gateway and create the necessary kustomizations. Hopefully, there aren't systems generating configurations (mostly VirtualServices) which aren't configurable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an MR to funnel all configurations for Gateways to the centralized CNP Ingress Gateways. This will allow for easier updates with Platform updates and will hopefully simplify the networking in AAW.