Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(contrib): knative manifest #363

Open
wg102 opened this issue Jun 30, 2023 · 0 comments
Open

Fix(contrib): knative manifest #363

wg102 opened this issue Jun 30, 2023 · 0 comments

Comments

@wg102
Copy link
Contributor

wg102 commented Jun 30, 2023

Found while looking at upgrade 1.7
See #350 for original ticket

Configuration that should be looked over

In looking at the configmap of config-istio in knative-serving

In our kustomize patch we have

  gateway.ingress-general-system.general-istio-ingress-gateway-https: general.ingress-general-system.svc.cluster.local
  local-gateway.istio-system.cluster-local-gateway: cluster-local-gateway.istio-system.svc.cluster.local
  local-gateway.mesh: mesh

which is fine, but when I check the output I see an additional line (the second one)

  gateway.ingress-general-system.general-istio-ingress-gateway-https: general.ingress-general-system.svc.cluster.local
  gateway.kubeflow.kubeflow-gateway: istio-ingressgateway.istio-system.svc.cluster.local
  local-gateway.istio-system.cluster-local-gateway: cluster-local-gateway.istio-system.svc.cluster.local
  local-gateway.mesh: mesh

with the important bit being the gateway.kubeflow because I see in a comment a few lines above # This is commented out as we don't want it exposed on the gateway since the authenticaion only works for kubeflow.

Do note that this also still matches what we currently have on the cluster, but should be reviewed if we want this entry in the configmap
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant