Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Path to Kubeflow 1.7 #1632

Closed
35 of 47 tasks
Jose-Matsuda opened this issue Apr 5, 2023 · 3 comments
Closed
35 of 47 tasks

[EPIC] Path to Kubeflow 1.7 #1632

Jose-Matsuda opened this issue Apr 5, 2023 · 3 comments
Assignees
Labels
kind/epic An epic

Comments

@Jose-Matsuda
Copy link
Contributor

Jose-Matsuda commented Apr 5, 2023

1.7 has released lets do a roadmap.

Kubeflow Central Dashboard

Jupyter-apis

once jupyter-apis is functional

Test and Debugging

Other

Some of these are comments that were thought while doing rebasing

  • make sure the volume and kubecost table are properly intergrated (mainly in config.ts and index-default.ts under the jupyter index component)
  • tslint.json: We had this file already, but there is now a eslintrc.json. We might want to delete the file once we confirm that it works (file is deleted and the linting still works. tslint is deprecated and it is recommended to use eslint)
  • karma.conf.js : Will need to confirm if the Karma tests are still useful and work. If the Files and proxies need to be more specific to our folder structures.
  • Deploy either locally, or on dev (relies on kubernetes 1.24)
  • [Epic] KF 1.7 Update manifests #1638
  • KF1.7 Deploy manifest to dev  #1729
  • Test and document kubeflow 1.7 on dev
  • Prepare for kubeflow 1.7 to prod
  • Verify why the metrics file is not working with more recent package.json fixes. We had to comment out a path
  • Fix(contrib): knative manifest aaw-kubeflow-manifests#363

Decisions to take

  • Do we want to get our icons back? They were removed from the form pages
  • Decide if we use tensorboard (probably not)

TODO in the future (maybe 1.8)


Old stuff

@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Apr 11, 2023

Crud-web-apps / Jupyter-apis Tasks

Note that we may be looking at moving to just the StatCan/kubeflow repo especially if the backend fix mentioned solves our problems / we don't need to maintain jupyter-apis. I do feel like this part of the 1.7 upgrade should wait until we have tested the possible performance enhancements, as we don't want to rebase on top of jupyter-apis only to find out we didnt need to.

Given that the release cadence of kubeflow seems to be every half year (and they don't seem to do patch releases) we would probably need to wait until October for 1.8.0 until the proposed backend fix has been added to an official release. We can choose to just pick that pr up and add it to our kubeflow branch and test it in the meantime if we want to.


Older information


Task List

  • placeholder rebase related commits 1 (basically the fix-1.6 issues)
  • ...

@Jose-Matsuda
Copy link
Contributor Author

Jose-Matsuda commented Apr 11, 2023

Centraldashboard

Should probably see how much customization there was, as we may not need to break this out into an epic. There was custom work done by the team since the 1.6 rebase but I don't think it should be too bad, especially since we're moving up a minor version anyways.

Upon talking with Bryan, who did the 1.6 rebase, we've agreed that this sort of ticket would be difficult to split out into smaller subtasks, and it's possibly really just a big ticket for one person to chew through.


Older Information

PR from 1.4 -> 1.6
Also this PR from Rohan --> CVE fix.


@rohank07 rohank07 removed their assignment May 10, 2023
@Souheil-Yazji
Copy link
Contributor

Stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/epic An epic
Projects
None yet
Development

No branches or pull requests

5 participants