Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some stuff, made a few small changes, removed Java 16 code #2

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Asbestosstar
Copy link

Before it was not working because of multiple issues with the Classloader which I have fixed. Its not perfect, but it at least boots into the game which it could not before. I have also removed some of the Java 16 and newer specific code to work on Java 8 and 11. This updated version was able to Launch on TL with my RHEL9 system. It even said modded (which for some reason it did not on Vanilla FC despite having similar JSON). Anyhow I hope this works for you.

Asbestosstar and others added 6 commits April 2, 2023 04:03
Before it was not working because of multiple issues with the Classloader which I have fixed. Its not perfect, but it at least boots into the game which it could not before.
I have also removed some of the Java 16 and newer specific code to work on Java 8 and 11.
This updated version was able to Launch on TL with my RHEL9 system. It even said modded (which for some reason it did not on Vanilla FC despite having similar JSON).
Anyhow I hope this works for you.
Copy link
Member

@TheKodeToad TheKodeToad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (lol totally not because i already fixed the problems i saw /s)!

@TheKodeToad TheKodeToad requested a review from Deftu April 2, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants