Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SN32: USB packet drops hotfix #49

Open
wants to merge 3 commits into
base: sn32_master
Choose a base branch
from

Conversation

Jpe230
Copy link
Collaborator

@Jpe230 Jpe230 commented Jul 7, 2022

Just letting the ball rolling, need testers to validate that nothing broke.

So far tested with VIA and OpenRGB in a macOS laptop and Win11 using Intel 9th gen.

Copy link

@susch19 susch19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the maybe solution is, keeping the weird workaround, clearing all the registers, setting the CFG during init and always handle ack and nack?
Seems to be pretty close, to what we got already, even though it's quite sad, that the workaround has to stay. But as long as it works, no one will notice :D

I'll test it as well, as soon as I find some time to do so, even though it seems, that alot of different versions seemed to be stable for me and completely breaking for others

|mskEP6_ACK|mskEP5_ACK|mskEP4_ACK|mskEP3_ACK|mskEP2_ACK|mskEP1_ACK
|mskEP6_NAK|mskEP5_NAK|mskEP4_NAK|mskEP3_NAK|mskEP2_NAK|mskEP1_NAK);

/* Keep only SETUP, TIMEOUT and reserved flags. */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the comment or the clearing is wrong, because you clear the setup flag.
Also, 27 and 28 are reserved, so why do you clear those (They are read only, so no real clearing takes places)?

@susch19
Copy link

susch19 commented Aug 20, 2022

I finally had time to test this, but for me this isn't working as intended. Via works sometimes, but not always and after ~10k Packages the connection to the keyboard stops working. So at least for me, this is a step back
It's crazy that from all of these solutions, non yielded the desired result for all of us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants