Chore/fixup unit tests for 0.55 api v12 release #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hub FW 0.55.x adds support for colorTemperature and colorControl commands to native handlers. And the lua libs are registering for default for those commands for Zigbee/matter devices.
framework There was a bug in the integration test framework that wasn't properly validating native handler registration api calls at the end of a test.
cjswedes
commented
Dec 11, 2024
drivers/SmartThings/matter-switch/src/test/test_matter_switch_device_types.lua
Outdated
Show resolved
Hide resolved
|
Channel deleted. |
Test Results 64 files 402 suites 0s ⏱️ Results for commit 20e4872. ♻️ This comment has been updated with latest results. |
|
matter-switch_coverage.xml
zigbee-switch_coverage.xml
zwave-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 20e4872 |
hcarter-775
reviewed
Dec 11, 2024
drivers/SmartThings/matter-switch/src/test/test_matter_switch_device_types.lua
Outdated
Show resolved
Hide resolved
cjswedes
force-pushed
the
chore/fixup-unit-tests
branch
from
556b0ac to
8805f1a
Compare
Its not clear if this fix is the correct fix or not.
cjswedes
force-pushed
the
chore/fixup-unit-tests
branch
from
8805f1a to
20e4872
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes unit tests to reflect new native handlers released in 0.55 FW/api v12 lua libs (Note we still need to enable colorTemperature and colorControl cmd registration in the matter-switch driver).
There was also an integration test framework bug that was fixed in api v12, that caused some tests to fail that should have never been passing (related to native handler registration for parent child/ mcd device)
One other test started failing with the integration test framework bugfix that needs analysis by someone more familiar with the matter profile switching