Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling up main to beta #1791

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Rolling up main to beta #1791

merged 3 commits into from
Dec 2, 2024

Conversation

cbaumler
Copy link
Contributor

@cbaumler cbaumler commented Dec 2, 2024

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

hdlee27 and others added 3 commits December 2, 2024 08:58
…#1764)

* fp2: add get_credential failure handling

Signed-off-by: hdlee27 <[email protected]>

* fp2: add nil check in eventsource

Signed-off-by: hdlee27 <[email protected]>

* fp2: Label change for easy distinction

Signed-off-by: hdlee27 <[email protected]>

* Offline event after reconnection attempt to prevent fake offline

* fp2: remove socket connection for fp2 resource

Signed-off-by: hdlee27 <[email protected]>

* fp2: update status when sse reconnect

Signed-off-by: hdlee27 <[email protected]>

* fp2: remove unused function

Signed-off-by: hdlee27 <[email protected]>

* fp2: manage online/offline by using SSE

Signed-off-by: hdlee27 <[email protected]>

* fp2: Change function order for fast response speed

Signed-off-by: hdlee27 <[email protected]>

* fp2: add error handling for status_update

Signed-off-by: hdlee27 <[email protected]>

* fp2: check sse connection before rest api check

Signed-off-by: hdlee27 <[email protected]>

---------

Signed-off-by: hdlee27 <[email protected]>
Copy link

github-actions bot commented Dec 2, 2024

Channel deleted.

Copy link

github-actions bot commented Dec 2, 2024

Test Results

   64 files  ±0    402 suites  ±0   0s ⏱️ ±0s
2 000 tests ±0  2 000 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 452 runs  ±0  3 452 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f150282. ± Comparison against base commit b472a5b.

Copy link

github-actions bot commented Dec 2, 2024

File Coverage
All files 71%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/init.lua 95%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-window-covering/src/matter-window-covering-position-updates-while-moving/init.lua 36%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against f150282

@cbaumler cbaumler merged commit 59c2715 into beta Dec 2, 2024
70 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants