Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Device (Matter Switch) Cync Reveal Full Color A21 #1788

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

lelandblue
Copy link
Contributor

@lelandblue lelandblue commented Dec 2, 2024

Check all that apply

Type of Change

  • [ X ] WWST Certification Request
  • Bug fix
  • New feature
  • Refactor

Checklist

  • [ X ] I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding a new fingerprint for the Cync Reveal Full Color A21 device. This device will be CxS. According to the Matter DCL this device is certified as a Matter device type = (0x10D)

Summary of Completed Tests

Copy link

github-actions bot commented Dec 2, 2024

Test Results

   64 files  ±0    402 suites  ±0   0s ⏱️ ±0s
2 000 tests ±0  2 000 ✅ ±0  0 💤 ±0  0 ❌ ±0 
3 452 runs  ±0  3 452 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit de7bd20. ± Comparison against base commit f150282.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 2, 2024

File Coverage
All files 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/aqara-cube/init.lua 96%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/eve-energy/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-switch/src/embedded-cluster-utils.lua 38%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against de7bd20

- id: "4921/107"
deviceLabel: Cync Reveal Full Color A19
vendorId: 0x1339
productId: 0x006D
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to be "Cync Reveal Full Color A21" instead of A19? It looks like that is what this productID is for according to the DCL, and the ticket mentions A21 as well (in the title of the ticket at least)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch Nick! I missed that. I will look to confirm....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I will approve

@nickolas-deboom nickolas-deboom changed the title New Device (Matter Switch) Cync Reveal Full Color A19 New Device (Matter Switch) Cync Reveal Full Color A21 Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

Channel deleted.

@lelandblue lelandblue merged commit ff3a213 into main Dec 3, 2024
11 checks passed
@lelandblue lelandblue deleted the new-device-Cync-Full-Color-A21 branch December 3, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants