Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don‘t merge now]Add device not support battery percent remaining attribute #1783

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Huangxiangjie
Copy link

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Add battery device vid witch does not support battery percent remaining attribute.

Summary of Completed Tests

Tested with hue device witch also does not support battery percent remaining attribute.

@Huangxiangjie Huangxiangjie changed the title Add device not support battery percent remaining attribute [Don‘t merge now]Add device not support battery percent remaining attribute Nov 26, 2024
for i = 1, #NOT_SUPPORT_BATTERY_PERCENT_REMAINING_VID do
if device.manufacturer_info.vendor_id == NOT_SUPPORT_BATTERY_PERCENT_REMAINING_VID[i] then
return false
end

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants