- Merge-Upstream: Rebased recent commits from rileytestut/AltSign - possibly removes need for 2FA code on iOS 18.1+ #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can’t call alt_setUserInfoValueProviderForDomain: from AltSign, so instead we just manually replicate the logic for returning correct NSLocalizedDescription value.
Also adds ALTUnderlyingAppleAPIErrorDomain to represent errors passed on directly from AppleAPI responses.
…’t exist -22406 is thrown when the password is incorrect, but -20101 is thrown when the provided email is incorrect.
|
@nythepegasus check this out and merge this if it is good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: I haven't looked in depth at Riley's code on why the 2FA requirement is gone now though.
This is just a rebase of rileytesut/AltSign on sidestore/AltSign with merge conflicts resolved.