-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paginate check run refresh #1325
Paginate check run refresh #1325
Conversation
900ef9e
to
3921ba8
Compare
I'm working on the CLA, but it's going to take a bit of time. I'm waiting for somebody with signing capacity to either sign the corporate CLA, or release this to me and I can do it as a personal contribution. |
Yeah, It's a PITA, sorry about that. Let me know once it's done. |
3921ba8
to
8c7a4e4
Compare
Apologies for the extreme delay here. I have signed the CLA. |
Sorry I was in vacation. Unfortunately, CI now fail, and that seems legit. |
I'll make some time to look into this soon |
@sjagoe @casperisfine I updated the tests to work with these changes. I created a PR from my fork to sjagoe fork here: https://github.com/sjagoe/shipit-engine/pull/1/files Not sure if this is the best way to do it, so happy to update as needed. |
Thanks for taking care of the tests @solojavier and sorry it came to you having to do that work. |
Thanks merging it. I'm happy to help :) |
Paginate check runs when fetching from GitHub to handle cases where more than 30 checks exist. #1323