Add debugger integration test for project with local Bundler settings #2882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
vinistock
force-pushed
the
11-07-merge_composed_bundle_environment_into_ruby_object
branch
from
0915b82
to
25f00de
Compare
vinistock
force-pushed
the
11-07-add_debugger_integration_test_for_project_with_local_bundler_settings
branch
from
c046f31
to
aefa155
Compare
vinistock
force-pushed
the
11-07-merge_composed_bundle_environment_into_ruby_object
branch
from
25f00de
to
2b3512d
Compare
vinistock
changed the base branch from
11-07-merge_composed_bundle_environment_into_ruby_object
to
graphite-base/2882
vinistock
force-pushed
the
graphite-base/2882
branch
from
2b3512d
to
fc2d91c
Compare
vinistock
force-pushed
the
11-07-add_debugger_integration_test_for_project_with_local_bundler_settings
branch
from
aefa155
to
5a61541
Compare
vinistock
force-pushed
the
11-07-add_debugger_integration_test_for_project_with_local_bundler_settings
branch
from
5a61541
to
05effda
Compare
andyw8
reviewed
Nov 25, 2024
| extensionUri: vscode.Uri.file( | ||
| path.dirname(path.dirname(path.dirname(__dirname))), | ||
| ), | ||
| } as unknown as vscode.ExtensionContext; |
andyw8
reviewed
Nov 25, 2024
| 'source "https://rubygems.org"\n', | ||
| ); | ||
| fs.writeFileSync( | ||
| path.join(workspacePath, "Gemfile.lock"), |
There was a problem hiding this comment.
Could this be read from a fixture?
andyw8
reviewed
Nov 25, 2024
| ); | ||
| } | ||
|
|
||
| const stub = sinon.stub(vscode.window, "activeTextEditor").get(() => { |
There was a problem hiding this comment.
Suggested change
| const stub = sinon.stub(vscode.window, "activeTextEditor").get(() => { | |
| const windowStub = sinon.stub(vscode.window, "activeTextEditor").get(() => { |
andyw8
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds an integration test to verify that we can launch the debugger properly for a project with Bundler settings.
This test fails in versions previous than v0.22.0 because we weren't returning the composed bundle env back to the extension, with the same failure reported in #1767 and #1785.