Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twitter logo added #62

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

Yashop181
Copy link

I have fixed the issue with the Twitter logo missing error and my PR is #32.

Copy link

@Imran-imtiaz48 Imran-imtiaz48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made:
• The src attribute for the Twitter image has been changed from twitter.png to twitter-squared.png.
Improvements:

  1. Consistency in HTML Structure: Ensure that each
    has a closing tag and that the structure is consistent.
  2. Use of Alt Attributes: Adding alt attributes to tags improves accessibility.
  3. Link Targets: If these links are meant to be placeholders, ensure they are clearly marked or consider using actual URLs if known.
  4. Optimization: If the image URLs are expected to change often, consider using a central configuration or constant to manage them.
    Improved Code:
    html
    Copy code
Instagram
Twitter
Behance
Key Points: • Ensure consistent HTML structure. • Use alt attributes for accessibility. • Placeholder links should be marked clearly or updated with actual URLs. • Consider managing frequently changing resources centrally.

@Yashop181
Copy link
Author

Refactored HTML to ensure consistent structure and added alt attributes for accessibility on images. Improved code readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants