Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nc-time-axis] QA refresh linter hooks #293

Merged
merged 22 commits into from
Nov 21, 2024
Merged

[nc-time-axis] QA refresh linter hooks #293

merged 22 commits into from
Nov 21, 2024

Commits on Nov 20, 2024

  1. Updated pre-commit-config.yaml with: 

      - trailing-whitespace hook
  - CI chore
  - global file list
    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4b37793 View commit details
    Browse the repository at this point in the history

  2. Added blacken-docs hook. 

      - Required manually disabling on @savefig lines in docs/examples.rst
  - Update files list to include doc/*.rst in filespre-commit-config.yaml
    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    e765304 View commit details
    Browse the repository at this point in the history

  3. small update to tpyes in codespell hook

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    696a76d View commit details
    Browse the repository at this point in the history

  4. Added Ruff linter to replace black, flake8 and isort. 

    Includes Ruff autofixes:
 - 11 × D212 (multi-line-summary-first-line)
 - 1 × RET506 (superfluous-else-raise)
 - 1 × RET505 (superfluous-else-return)
 - 1 × I001 (unsorted-imports)
Added `PLR5501` to exclude list to preserve readability of TODO
block in convert method
    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    01d78a4 View commit details
    Browse the repository at this point in the history

  5. Ignores for Ruff linter

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    12bdf3a View commit details
    Browse the repository at this point in the history

  6. Autofixes

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    12cc421 View commit details
    Browse the repository at this point in the history

  7. Added mypy linter and exceptions

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4efd098 View commit details
    Browse the repository at this point in the history

  8. Added numpydoc and exceptions

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0096af3 View commit details
    Browse the repository at this point in the history

  9. Reorder hooks alphabetically

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    754f073 View commit details
    Browse the repository at this point in the history

  10. Added sort-all hook

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    dce0db9 View commit details
    Browse the repository at this point in the history

  11. Added validate-pyproject hook

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    d362f73 View commit details
    Browse the repository at this point in the history

  12. Added sp-repo-review hook and excludes. 

      - Applied some fixes to [tool.pytest.ini_options]
    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8347ea8 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Added references to SciTools linters Wiki

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    0b3dbdb View commit details
    Browse the repository at this point in the history

  2. Fixed repo-review "PP304" [Sets the log level in pytest]

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    3970ef5 View commit details
    Browse the repository at this point in the history

  3. Fixed sp-repo-review: "GH212" [Require GHA update grouping]

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6e3db2b View commit details
    Browse the repository at this point in the history

  4. Removed wheel from build (Fixes sp-repo-review "PP003")

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    43bac01 View commit details
    Browse the repository at this point in the history

  5. Alphabetised pyproject.toml sections (manually)

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    de7d178 View commit details
    Browse the repository at this point in the history

  6. Try to fix brocken docs build

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    4428be5 View commit details
    Browse the repository at this point in the history

  7. Fixed docs build (had to make .. blacken-docs:off apply to whole co… 

    …de block
    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1c6f9f6 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into qa_refresh_pre-commit_hooks

    @ukmo-ccbunney
    ukmo-ccbunney authored Nov 21, 2024
    Configuration menu
    Copy the full SHA
    b0dcb83 View commit details
    Browse the repository at this point in the history

  9. Better comment on ruff select list

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f40532e View commit details
    Browse the repository at this point in the history

  10. Added annotations to ruff ignore list

    @ukmo-ccbunney
    ukmo-ccbunney committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    9e31436 View commit details
    Browse the repository at this point in the history