PORTALS-3308 - What's in Portals Component (GoalsV2) #1399
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
afwillia
changed the title
afwillia
changed the title
nickgros
added
the
chromatic
packages/synapse-react-client/src/components/GoalsV2/GoalsV2.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/GoalsV2/GoalsV2.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/GoalsV2/GoalsV2.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/GoalsV2/GoalsV2.tsx
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/style/components/_goalsv2.scss
Outdated
Show resolved
Hide resolved
packages/synapse-react-client/src/components/GoalsV2/GoalsV2.test.tsx
Outdated
Show resolved
Hide resolved
| title, | ||
| }: GoalsV2DataProps) { | ||
| const titleElement = ( | ||
| <div className="GoalsV2__Mobile__Header"> |
There was a problem hiding this comment.
Go ahead and remove all classNames that are not being used for styling
|
|
||
| const queryClient = new QueryClient() | ||
|
|
||
| const server = setupServer( |
There was a problem hiding this comment.
No need to call setupServer, we do that already. You can import server from '../mocks/msw/server'
| const queryClient = new QueryClient() | ||
|
|
||
| const server = setupServer( | ||
| rest.post( |
There was a problem hiding this comment.
Your handlers look good, but we have a utility generateAsyncJobHandlers that can abstract away setting up the async/start and async/get handlers that might reduce the amount of code here. Optionally consider using that here
There was a problem hiding this comment.
You can delete this file, I'm trying to work towards removing these index files (for performance) and it's no longer true that the component must be exported this way to use it in a portal.
| <Link | ||
| href={dataLink} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| fontFamily="Lato" | ||
| fontSize="18" | ||
| fontStyle="semi-bold" | ||
| > |
There was a problem hiding this comment.
Remove this Link component since you're already using a Button with an href
| sx={{ | ||
| backgroundColor: '#5BA998', | ||
| border: '1px solid white', | ||
| boxShadow: 'none', |
There was a problem hiding this comment.
You can just remove the box shadow from all states (hover, active) with !important here. Should be safe since it only applies to this specific button.
That said, I think @kianamcc is moving these button styles to the EL Home Page theme override in #1456, so you might be able to remove some of these style overrides entirely
| boxShadow: 'none', | |
| boxShadow: 'none !important', |
| variant="headline1" | ||
| style={{ | ||
| color: 'grey.1000', | ||
| fontFamily: 'Merriweather', |
There was a problem hiding this comment.
Should be unnecessary now that this is in the HomePageThemeProvider in the EL Portal
| fontFamily: 'Merriweather', |
| setAssets( | ||
| files.requestedFiles | ||
| .filter(el => el.preSignedURL !== undefined) | ||
| .map(el => el.preSignedURL!), |
There was a problem hiding this comment.
I am slightly concerned about these presigned URLs expiring, but this hasn't been an issue with the Goals v1 component, so I think it's fine for now.
| const goalsDataArray: GoalsV2DataProps[] = [] | ||
|
|
||
| queryResultBundle?.queryResult!.queryResults.rows.forEach((el, index) => { |
There was a problem hiding this comment.
You could use Array,map instead of forEach, but it's basically the same
PORTALS-3308 This PR modifies the Goals component by creating cards for each panel, surrounded by a box.