IT-3964: Add workaround for missing glibc on node20 runners #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaro0508
requested changes
Oct 28, 2024
.github/workflows/main.yaml
Outdated
| @@ -34,3 +34,4 @@ jobs: | |||
| DB_HOST: ${{ secrets.DB_HOST }} | |||
| DB_USER: ${{ secrets.DB_USER }} | |||
| DB_PASS: ${{ secrets.DB_PASS }} | |||
| ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true | |||
There was a problem hiding this comment.
The error is happening in the actions/checkout@v2 step however i think this env block is scoped to the Import Synapse Data step. i would move this env to the global environment on line 23 so that it applies to all steps in this GH action job.
There was a problem hiding this comment.
@zaro0508 It didn't like it when I added the config to deploy.environment:
So I added deploy.env and put it there.
There was a problem hiding this comment.
according to the github action docs, my suggestion seems solid. maybe your schema validator needs an update?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.