-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable SP7 testing #582
base: main
Are you sure you want to change the base?
Enable SP7 testing #582
Conversation
@dcermak rebase? we need to get this in soonish when 15.7 development starts (I'd be fine with testing all of base/minimal for now, similar to how 16.0 is enabled) |
8d43acb
to
ed82c7c
Compare
the xfail will ensure that we get failures once the repo becomes available
@@ -376,6 +376,13 @@ def test_no_orphaned_packages(container_per_test: ContainerData) -> None: | |||
@pytest.mark.parametrize( | |||
"container", CONTAINERS_WITH_ZYPPER_AS_ROOT, indirect=True | |||
) | |||
@pytest.mark.xfail( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to break tests on 15.4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, because they're run on a non-suse host so the container-suseconnect integration is not working. rather than adding a quirk in the tests for this, maybe we should simply not define a repo like in the 16.0 case?
@@ -167,6 +165,14 @@ jobs: | |||
os_version: "16.0" | |||
- toxenv: kernel_module | |||
os_version: "16.0" | |||
- toxenv: all | |||
os_version: "15.7" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
although don't have a strong opinion, I think sorting these before the "16.0" section would be slightly more logical.
@@ -519,7 +519,7 @@ def create_BCI( | |||
) | |||
PYTHON311_CONTAINER = create_BCI( | |||
build_tag="bci/python:3.11", | |||
available_versions=_DEFAULT_NONBASE_OS_VERSIONS, | |||
available_versions=["15.6", "tumbleweed"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 311 is still available with SP7, why this change?
This will not work properly before we have the SLE 15 SP7 BCI repo
This fixes #545