Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of the ironbank base container #555

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dirkmueller
Copy link
Member

The ironbank base container is a fips container but actually called bci-base.

Copy link
Collaborator

@dcermak dcermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it maybe make the handling a bit simpler if we added bci-base to BASE_FIPS_CONTAINERS if the target is "dso"?

@dirkmueller
Copy link
Member Author

Would it maybe make the handling a bit simpler if we added bci-base to BASE_FIPS_CONTAINERS if the target is "dso"?

not really, because we expect BASE_CONTAINER to be always existing and exactly one container everywhere. I've pushed an additional commit to do what you're asking for. I think the previous solution was simpler.

The ironbank base container is a fips container but actually
called bci-base.
Thereby we can keep it as an empty list in the DSO case and
just assign a FIPS container.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants