-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 3.10, add 3.12 #444
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please adjust the branch protection rules again
we first need to convert the tox runs to use python 3.12 instead of 3.10 before merging this |
4fbc66b
to
b6de9db
Compare
Ubuntu 22.04 is the only one with 3.10, we replace that with 24.04 which uses 3.12
@@ -17,6 +19,7 @@ deps = | |||
doc: Sphinx | |||
|
|||
[testenv] | |||
basepython = python3.11 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason why you are hardcoding the tests to use python 3.11? That will cause a giant headache for QA, who are using the system python in openQA.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is still a draft, I'm trying to find a workable path forward to get it to not use the system python. however, for SLE15 I don't see a problem with requiring python311 for the QA team. it might be more difficult for the tests on non-SLE hosts, but one problem at a time.
Ubuntu 22.04 is the only one with 3.10, we replace that with 24.04 which uses 3.12