Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Umi/1week #5

Merged
merged 7 commits into from
Apr 11, 2024
Merged

Umi/1week #5

merged 7 commits into from
Apr 11, 2024

Conversation

jejejekim
Copy link

개요⭐️

#1 미션 완료했습니다!

작업사항⭐️

  • 회원가입 구현
  • 투두리스트 구현

확인⭐️

  • 워크북 키워드 정리 완료
  • 실습은 못했지만(ㅠㅠ) 필수인 미션은 완료했습니다!

@ssolfa
Copy link

ssolfa commented Apr 11, 2024

LGTM❤️

@sihyun2988
Copy link
Contributor

LGTM!!

yeon-dong
yeon-dong reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@yeon-dong yeon-dong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM이요~~~

@yeon-dong yeon-dong self-requested a review April 11, 2024 03:58
yeon-dong
yeon-dong approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@yeon-dong yeon-dong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다시 LGTM이요~

sihyun2988
sihyun2988 approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@sihyun2988 sihyun2988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ssolfa ssolfa requested review from yeon-dong and sihyun2988 April 11, 2024 03:59
ssolfa
ssolfa approved these changes Apr 11, 2024
View reviewed changes
Copy link

@ssolfa ssolfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM❤️

@jejejekim jejejekim requested a review from iamyeongg April 11, 2024 04:03
@jejejekim jejejekim merged commit c3902cb into umi/main Apr 11, 2024
@jejejekim jejejekim deleted the umi/1week branch April 13, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssolfa ssolfa ssolfa approved these changes

@yeon-dong yeon-dong Awaiting requested review from yeon-dong

@sihyun2988 sihyun2988 Awaiting requested review from sihyun2988

@iamyeongg iamyeongg Awaiting requested review from iamyeongg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jejejekim @ssolfa @sihyun2988 @yeon-dong