Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ming] Chpater08_API 응답 통일 & 에러 핸들러 #34

Merged
merged 4 commits into from
Jun 23, 2024
Merged

[ming] Chpater08_API 응답 통일 & 에러 핸들러 #34

merged 4 commits into from
Jun 23, 2024

Conversation

qzzloz
Copy link
Member

@qzzloz qzzloz commented Jun 12, 2024 •
edited
Loading

#️⃣ 연관된 이슈


✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 기록하셨나요?
  • 미션을 수행하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?
  • 적절한 라벨을 설정하였나요?
  • 스터디원들에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?

📌 주안점

@qzzloz qzzloz added the ✨ Chapter08 챕터 8 label Jun 12, 2024
@qzzloz qzzloz requested review from ryogaeng and Gusionling June 12, 2024 07:45
@qzzloz qzzloz self-assigned this Jun 12, 2024
@qzzloz qzzloz changed the title Chpater08_API 응답 통일 & 에러 핸들러 [ming] Chpater08_API 응답 통일 & 에러 핸들러 Jun 12, 2024
ryogaeng
ryogaeng approved these changes Jun 12, 2024
View reviewed changes
Copy link

@ryogaeng ryogaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

시험기간임에도 불구하고 고생하셨습니다!

chaeyeon0130
chaeyeon0130 requested changes Jun 17, 2024
View reviewed changes
Copy link
Member

@chaeyeon0130 chaeyeon0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

밍님!! 시험기간인데도 8주차 키워드 잘 정리해주셔서 감사합니다💓
호옥시 미션 수행 내용은 어디서 확인하면 되는 걸까요..?🤩

@qzzloz
Copy link
Member Author

qzzloz commented Jun 18, 2024

밍님!! 시험기간인데도 8주차 키워드 잘 정리해주셔서 감사합니다💓 호옥시 미션 수행 내용은 어디서 확인하면 되는 걸까요..?🤩

노션에 추가하는 걸 깜빡했습니다ㅠㅠ 방금 깃허브 링크와 스크린샷 추가했습니다!

chaeyeon0130
chaeyeon0130 approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@chaeyeon0130 chaeyeon0130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!💓

@qzzloz qzzloz merged commit 9c487b6 into ming/main Jun 23, 2024
@qzzloz qzzloz deleted the ming/#29 branch June 23, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaeyeon0130 chaeyeon0130 chaeyeon0130 approved these changes

@Gusionling Gusionling Gusionling approved these changes

@ryogaeng ryogaeng ryogaeng approved these changes

Assignees

@qzzloz qzzloz

Labels
✨ Chapter08 챕터 8
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qzzloz @ryogaeng @Gusionling @chaeyeon0130